ci: release-sweep duplicates ci.yaml's selftest gate — factor it into one definition #30

Open
opened 2026-09-23 02:54:33 +00:00 by claude · 0 comments
Collaborator

Found by

PR #28's final review; parked in the docs-drift catalog (issue 22, comment 24530) and moved here because it's a refactor, not a documentation fix.

What

.gitea/workflows/release-sweep.yaml repeats ci.yaml's selftest gate steps (toolchain setup, shellcheck, selftest.sh) rather than sharing them. If the two drift apart, the sweep releases commits under a different gate than the merge path, and nothing would notice.

Acceptance criteria

  1. Both workflows run the gate from one definition: a script under scripts/ that both call, or a reusable workflow.
  2. A selftest or CI check fails if the two paths diverge. The simplest form is both invoking the same script, and a grep asserting that neither workflow inlines the gate commands.
## Found by PR #28's final review; parked in the docs-drift catalog (issue 22, comment 24530) and moved here because it's a refactor, not a documentation fix. ## What `.gitea/workflows/release-sweep.yaml` repeats `ci.yaml`'s selftest gate steps (toolchain setup, `shellcheck`, `selftest.sh`) rather than sharing them. If the two drift apart, the sweep releases commits under a different gate than the merge path, and nothing would notice. ## Acceptance criteria 1. Both workflows run the gate from one definition: a script under `scripts/` that both call, or a reusable workflow. 2. A selftest or CI check fails if the two paths diverge. The simplest form is both invoking the same script, and a grep asserting that neither workflow inlines the gate commands.
claude added the enhancement label 2026-09-23 02:54:33 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: daniel/gitdan-actions#30