fix(ci): trigger on edited so un-drafting actually lifts the draft skip #18

Merged

claude merged 4 commits from fix/ci-edited-trigger into main 2026-09-02 18:54:43 +00:00

Conversation 3 Commits 4 Files Changed 2

+51 -18

4 Commits

Author	SHA1	Message	Date
claudeandClaude Opus 5	5abd0a9968	docs(ci): name the timing fields this forge actually returns ... The accepted-cost derivation cited `run_started_at` and `updated_at`, which are GitHub's field names. This Gitea's runs payload has neither -- it returns `started_at` and `completed_at`, and omits `run_started_at`, `updated_at` and `created_at` entirely (confirmed by dumping the keys of a run object). The figures are unaffected: the script that produced them fell through to the real fields, so 83 s median over 77-106 s stands. The derivation was named so a reader could re-take the measurement, and as written it returned nothing when followed literally, which defeats the only reason it was there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjbhSqQf3pwnPA6MVaWcWL	2026-09-02 13:03:45 -05:00
claudeandClaude Opus 5	8217f53d4a	docs(ci): measure the accepted cost instead of comparing it unmeasured ... The accepted-cost paragraph claimed this repo's job made the `edited` trade worse than in the sibling repos that shipped it first, reasoning from the toolchain install, the Cargo-driving suites and `timeout-minutes: 20`. The measurement inverts it: last twelve non-skipped runs here are 83 s median (77-106), against ~118 s for daniel/gitdan and ~330 s for daniel/emowheel -- this is the cheapest of the three, and 20 minutes is a hang ceiling, not a duration. This PR's own runs measured 87 s and 90 s. The comparison is dropped rather than re-pointed; the absolute figure replaces it, with the derivation named (`run_started_at` to `updated_at` off the Actions API) so a reader can re-take it. The neighbouring concurrency claim was read off this repo's own file and is unchanged -- it was the checked half of a paragraph whose other half was not. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjbhSqQf3pwnPA6MVaWcWL	2026-09-02 12:55:24 -05:00
claudeandClaude Opus 5	5b6acd7b3b	docs(ci): date the cancellation observation to 1.26.0, not the current version ... The concurrency note said "this Gitea (1.26.0)" while `GET /version` now returns 1.27.2 — the instance was upgraded on 2026-08-25/26 (daniel/gitdan's runbook, gitdan#46). Swapping the number would have asserted the cancellation was observed on 1.27.2, which nobody has checked: the runs it cites were seen before the upgrade. The comment now dates the observation to 1.26.0, names the current version, and says persistence is unverified — which is why every commit gets its own group rather than trusting `cancel-in-progress`. That reasoning is unchanged; only the implied currency was wrong. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjbhSqQf3pwnPA6MVaWcWL	2026-09-02 12:49:56 -05:00
claudeandClaude Opus 5	b791896e03	fix(ci): trigger on edited so un-drafting actually lifts the draft skip ... `ready_for_review` does not exist as a pull_request action on this Gitea, so it never fired and the draft skip never lifted: a PR opened as `WIP:` carried its skip decision to merge unless a later push happened to create a run. Draft here is not a persisted column — it is the `WIP:` title prefix, derived by `issue.IsWorkInProgress` — so un-drafting is a title edit, which fires a plain `edited`. Ported from daniel/emowheel commit 08da820 (see daniel/emowheel#71) and daniel/gitdan (see daniel/gitdan#92), where the identical change landed first. Accepted cost: Gitea populates no `changes` field for a title-or-body edit, so the workflow cannot tell an un-drafting edit from an ordinary body PATCH, and every body edit on a non-draft PR now starts a real run. That is a heavier trade here than in the sibling repos -- this job installs two Rust toolchains and drives a real Cargo, at `timeout-minutes: 20` -- but the `concurrency:` block groups `pull_request` runs on `github.ref` with `cancel-in-progress: true`, so a burst of edits collapses to one run. Still-draft PRs are unchanged. Docs: the workflow comment is rewritten and shortened, and README's Development section retires the empty-commit workaround it prescribed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjbhSqQf3pwnPA6MVaWcWL	2026-09-02 12:34:24 -05:00